Lpar integration - installation on LPAR as nodes #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmadeusPodvratnik
requested changes
Mar 6, 2024
There was a problem hiding this comment.
Hi @sandisamp , thx for the PR. Following additonal comments:
- There is a description missing what support you are adding (lpar).
- You need to document what your are supporting (Classic vs. DPM, fcp device, etc).
- You have additional variables defined which needed to be explained and described.
- In your boot_LPAR task I do not see a interface name and you are supporting ipv4 only ... is this correct?
sandisamp
changed the title
smolin-de
reviewed
Mar 27, 2024
AmadeusPodvratnik
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Hi @sandisamp Thx for the lpar. Pls add the description of the lpar to section 3 (Step 3: Set Variables (host_vars)) for the time being.
In addition pls add a section to the Readme.md (New features) and add your lpar support to it.
AmadeusPodvratnik
requested changes
Apr 9, 2024
sandisamp
force-pushed
the
LPAR_integration
branch
3 times, most recently
from
7462195
to
45110a6
Compare
smolin-de
reviewed
May 21, 2024
added 2 commits
June 4, 2024 14:48
Signed-off-by: Sanidhya <sanidhya@Sanidhyas-MacBook-Pro.local>
sandisamp
force-pushed
the
LPAR_integration
branch
from
f76efb7
to
c901b11
Compare
smolin-de
reviewed
Jun 4, 2024
AmadeusPodvratnik
approved these changes
Jun 5, 2024
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create integration of LPAR into playbook - 6_create_nodes
Accordingly tasks and roles have been created.
Note: This PR is a work in progress. Created for initial reviews and not to make the review process too long. Will update detailed description when PR is ready.